[wp-trac] [WordPress Trac] #19592: Automate script and style compression and bumps
WordPress Trac
wp-trac at lists.automattic.com
Sat Feb 18 21:05:59 UTC 2012
#19592: Automate script and style compression and bumps
-------------------------+------------------
Reporter: nacin | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 3.4
Component: General | Version:
Severity: normal | Resolution:
Keywords: |
-------------------------+------------------
Comment (by azaozz):
Replying to [comment:14 duck_]:
> In this case it's ISO-8859-1 that's required.
My bad, it was late and didn't look into this more. It seems we may be
running into this whenever non-ascii chars are present in the files. From
YUI Compressor's description:
{{{
--charset character-set
If a supported character set is specified, the YUI Compressor will
use it
to read the input file. Otherwise, it will assume that the
platform's
default character set is being used. The output file is encoded
using
the same character set.
}}}
Thinking we should keep it UTF-8 as that affects the output too. Perhaps
it's worth it having some basic charset detection or running
`mb_detect_encoding()`. Alternatively can try to detect invalid chars in
the output and not commit that minified file, showing a warning in the
commit message.
In that particular case the file comes pre-minified in the TinyMCE
distribution package and we will be skipping processing the pre-minified
files there as discussed with @nacin in IRC.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/19592#comment:17>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list