[wp-trac] [WordPress Trac] #19815: Theme install and search screens should infinitely scroll

WordPress Trac wp-trac at lists.automattic.com
Wed Feb 15 08:46:40 UTC 2012


#19815: Theme install and search screens should infinitely scroll
----------------------------+------------------
 Reporter:  helenyhou       |       Owner:
     Type:  task (blessed)  |      Status:  new
 Priority:  normal          |   Milestone:  3.4
Component:  Themes          |     Version:  3.3
 Severity:  normal          |  Resolution:
 Keywords:                  |
----------------------------+------------------

Comment (by garyc40):

 In [attachment:19815.8.diff], the throttle still doesn't work properly. To
 test this, simply add `console.log('maybeLoad!');` at the beginning of the
 maybeLoad function. You'll see that it's called every single time the
 scroll event is triggered. Function call is expensive.

 [attachment:19815.9.diff] has some improvement on the throttling method:
 - Since we're polling every xxx milliseconds anyways, there's practically
 no need for scroll event handler.
 - Threshold is checked right in the polling function, rather than in
 maybeLoad. This saves a function call every time we're polling.
 - scrollThrottleDelay is increased to 500.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/19815#comment:31>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list