[wp-trac] [WordPress Trac] #16892: make_clickable segfault
WordPress Trac
wp-trac at lists.automattic.com
Fri Feb 10 14:06:02 UTC 2012
#16892: make_clickable segfault
-------------------------------------------------+-------------------------
Reporter: westi | Owner: duck_
Type: defect (bug) | Status: closed
Priority: normal | Milestone: 3.4
Component: Formatting | Version: 3.1
Severity: normal | Resolution: fixed
Keywords: has-patch needs-testing 3.4-early |
westi-likes |
-------------------------------------------------+-------------------------
Comment (by duck_):
Replying to [comment:29 TobiasBg]:
> as a "(" as the first character (i.e. position 0) would be returned as
falsy. If this is by design, {{{strpos( $url, '(' ) > 0}}} would be
clearer, or if we want to recognize "(" as the first character, this needs
to be {{{false === strpos( $url, '(' )}}}.
Since "(" cannot be the first character of `$url` I don't think this
matters. However, I'm not against `false !== strpos( $url, '(' )` to be
explicit.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/16892#comment:30>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list