[wp-trac] [WordPress Trac] #16892: make_clickable segfault

[WordPress Trac]

#16892: make_clickable segfault
-------------------------------------------------+-------------------------
 Reporter:  westi                                |       Owner:  duck_
     Type:  defect (bug)                         |      Status:  reviewing
 Priority:  normal                               |   Milestone:  3.4
Component:  Formatting                           |     Version:  3.1
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch needs-testing 3.4-early    |
  westi-likes                                    |
-------------------------------------------------+-------------------------

Comment (by westi):

 Replying to [comment:25 duck_]:
 > Replying to [comment:21 mdawaffe]:
 > > I'm sure there are some edge cases that this patch treats differently
 than the current code.  I'm not sure if those edge case come up
 "naturally".  If they do, I'm not sure if they have well defined expected
 behaviors.
 >
 > A URL following punctuation without a space (likely due to a typo) is
 one situation that the current function allows for, but the patch does
 not.
 >
 > {{{
 > Comma, no space, URL,http://example.com/.
 > }}}
 >
 > We might want to add some more punctuation to the character class in the
 first subgroup to accommodate for this.

 Sounds like a good idea.

 I think the lack of space in this test case is probably a quite common
 occurrence in comments typed in haste.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/16892#comment:26>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software