[wp-trac] [WordPress Trac] #16434: Give site admin ability to upload favicon in Settings, General
WordPress Trac
wp-trac at lists.automattic.com
Thu Feb 9 22:22:12 UTC 2012
#16434: Give site admin ability to upload favicon in Settings, General
-----------------------------+------------------
Reporter: jane | Owner:
Type: feature request | Status: new
Priority: normal | Milestone: 3.4
Component: Administration | Version: 3.1
Severity: normal | Resolution:
Keywords: |
-----------------------------+------------------
Comment (by Otto42):
If you're going to support IE and add ICO files for them, don't use
browser sniffing.
You can use code like this:
{{{
<link href="http://example.com/favicon.ico" rel="shortcut icon"
type="image/x-icon" />
<link href="http://example.com/favicon.png" rel="icon" type="image/png" />
}}}
This appears to work fine to me as long as the "shortcut icon" with the
ICO file is first in the HTML.
Alternatively, the really correct way to do this is with conditional tags.
{{{
<!--[if IE]>
<link href="http://example.com/favicon.ico" rel="shortcut icon"
type="image/x-icon" />
<![endif]-->
}}}
Non-IE browsers will then ignore the ICO file.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/16434#comment:39>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list