[wp-trac] [WordPress Trac] #18536: Improve performance of WP_Query core

WordPress Trac wp-trac at lists.automattic.com
Wed Feb 1 07:59:32 UTC 2012


#18536: Improve performance of WP_Query core
--------------------------------------------------+------------------
 Reporter:  cheald                                |       Owner:
     Type:  task (blessed)                        |      Status:  new
 Priority:  normal                                |   Milestone:  3.4
Component:  Performance                           |     Version:
 Severity:  normal                                |  Resolution:
 Keywords:  early has-patch commit needs-testing  |
--------------------------------------------------+------------------
Changes (by market4android):

 * cc: market4android (added)


Comment:

 I just tried to apply the 18536.5.diff to my live installation of
 wordpress 3.3.1 and it failed. Here's my shell's output:

 (Note: I used 18536.5.diff but I removed the .5 after I uploaded the file
 to my server for mind's sake.)


 {{{
 $ patch < 18536.diff
 Hmm...  Looks like a unified diff to me...
 The text leading up to this was:
 --------------------------
 |Index: wp-includes/post.php
 |===================================================================
 |--- wp-includes/post.php       (revision 19788)
 |+++ wp-includes/post.php       (working copy)
 --------------------------
 Patching file post.php using Plan A...
 Hunk #1 succeeded at 5328 (offset 8 lines).
 Hmm...  The next patch looks like a unified diff to me...
 The text leading up to this was:
 --------------------------
 |Index: wp-includes/functions.php
 |===================================================================
 |--- wp-includes/functions.php  (revision 19788)
 |+++ wp-includes/functions.php  (working copy)
 --------------------------
 Patching file functions.php using Plan A...
 Hunk #1 succeeded at 3699 with fuzz 2.
 Hmm...  The next patch looks like a unified diff to me...
 The text leading up to this was:
 --------------------------
 |Index: wp-includes/query.php
 |===================================================================
 |--- wp-includes/query.php      (revision 19788)
 |+++ wp-includes/query.php      (working copy)
 --------------------------
 Patching file query.php using Plan A...
 Hunk #1 succeeded at 1952 (offset 1 line).
 Hunk #2 succeeded at 2600 (offset 2 lines).
 Hunk #3 failed at 2634.
 Hunk #4 succeeded at 2668 (offset 1 line).
 Hunk #5 succeeded at 2771 (offset 2 lines).
 1 out of 5 hunks failed--saving rejects to query.php.rej
 Hmm...  The next patch looks like a unified diff to me...
 The text leading up to this was:
 --------------------------
 |Index: wp-includes/formatting.php
 |===================================================================
 |--- wp-includes/formatting.php (revision 19788)
 |+++ wp-includes/formatting.php (working copy)
 --------------------------
 Patching file formatting.php using Plan A...
 Hunk #1 succeeded at 3018 with fuzz 2 (offset -1 lines).
 patch: **** misordered hunks! output would be garbled
 }}}


 When I tried to undo the patch that I applied, here's the output :


 {{{
 $ patch -R < 18536.diff
 Hmm...  Looks like a unified diff to me...
 The text leading up to this was:
 --------------------------
 |Index: wp-includes/post.php
 |===================================================================
 |--- wp-includes/post.php       (revision 19788)
 |+++ wp-includes/post.php       (working copy)
 --------------------------
 Patching file post.php using Plan A...
 Hunk #1 succeeded at 5328 (offset 8 lines).
 Hmm...  The next patch looks like a unified diff to me...
 The text leading up to this was:
 --------------------------
 |Index: wp-includes/functions.php
 |===================================================================
 |--- wp-includes/functions.php  (revision 19788)
 |+++ wp-includes/functions.php  (working copy)
 --------------------------
 Patching file functions.php using Plan A...
 Unreversed (or previously applied) patch detected!  Ignore -R? [y] n
 Apply anyway? [n] y
 Hunk #1 failed at 3699.
 1 out of 1 hunks failed--saving rejects to functions.php.rej
 Hmm...  The next patch looks like a unified diff to me...
 The text leading up to this was:
 --------------------------
 |Index: wp-includes/query.php
 |===================================================================
 |--- wp-includes/query.php      (revision 19788)
 |+++ wp-includes/query.php      (working copy)
 --------------------------
 Patching file query.php using Plan A...
 Hunk #1 succeeded at 1952 (offset 1 line).
 Hunk #2 succeeded at 2599 (offset 2 lines).
 Hunk #3 failed at 2628.
 Hunk #4 succeeded at 2630 (offset -15 lines).
 Hunk #5 succeeded at 2756 (offset 2 lines).
 1 out of 5 hunks failed--saving rejects to query.php.rej
 Hmm...  The next patch looks like a unified diff to me...
 The text leading up to this was:
 --------------------------
 |Index: wp-includes/formatting.php
 |===================================================================
 |--- wp-includes/formatting.php (revision 19788)
 |+++ wp-includes/formatting.php (working copy)
 --------------------------
 Patching file formatting.php using Plan A...
 Hunk #1 succeeded at 3018 with fuzz 2 (offset -1 lines).
 patch: **** misordered hunks! output would be garbled
 }}}

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/18536#comment:54>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list