[wp-trac] [WordPress Trac] #22841: New media uploader ignores option image_default_link_type
WordPress Trac
noreply at wordpress.org
Fri Dec 28 21:52:34 UTC 2012
#22841: New media uploader ignores option image_default_link_type
--------------------------+--------------------
Reporter: Ipstenu | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.5.1
Component: Media | Version: 3.5
Severity: major | Resolution:
Keywords: |
--------------------------+--------------------
Comment (by azaozz):
Yes, I remember some discussions (long time ago) whether the defaults for
`image_default_link_type`, `image_default_align` and `image_default_size`
should be "user state", i.e. we reuse the last value the user has chosen,
or should be shown as options in Settings -> Media.
At one point (around WP 2.5?) these were shown as options, then converted
to user states, then changed to use the options when set (it's possible to
set these with a plugin in newer versions).
Now that we have new workflow for most media actions, thinking we should
choose one method and stick to it, perhaps making it easier for plugins to
implement the other.
We can fall back to something similar to the 3.4 behavior but thinking we
should empty the DB options for new installs (set all of them to `''`).
Then if any of the three options is non-empty, we always load the value
from there as default. The user would be able to select another value in
the UI but it will only be used for the current image (and not saved in
"user state"?).
Alternatively the DB options can be deemed "plugin territory". To make it
easier to implement we could have a var in JS that will turn off saving of
user state for the three options so the defaults will always be used, and
plugins can set these defaults in any way they want. This would change the
3.4 behavior a bit but only for the first use.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/22841#comment:10>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list