[wp-trac] [WordPress Trac] #21947: Fix 3-column dashboard display

[WordPress Trac]

#21947: Fix 3-column dashboard display
----------------------------+------------------------------
 Reporter:  belg4mit        |       Owner:
     Type:  defect (bug)    |      Status:  new
 Priority:  low             |   Milestone:  Awaiting Review
Component:  Administration  |     Version:  3.4
 Severity:  normal          |  Resolution:
 Keywords:  ui-focus        |
----------------------------+------------------------------

Comment (by belg4mit):

 Replying to [comment:5 azaozz]:
 > Related #17586.
 ...
 > In any case that css is in need of improvement. It should separate 3 and
 4 columns the same way it separates 1, 2 and [more]. @belg4mit would you
 be willing to patch that?

 That's an odd screenshot, but as you noted in the other ticker, the
 purpose of the multiple settings is to let the user pick the best one,
 esp. since browswers differ in their interpretations of CSS i.e; the
 column margins should prevent that, given that that there are no positive
 min-widths for their contents. Added is a patch to disentangle the 3 and 4
 column options. Setting additional columns is left as an exercise for the
 reader.

 It also lowers the threshold for two columns to match the absolute minimum
 of 300px per column for the dashboard itself, not the editor. And it
 removes some (seemingly) redundant code:


 {{{
         #dashboard-widgets #postbox-container-3 .empty-container,
         #dashboard-widgets #postbox-container-4 .empty-container {
                 border: 0 none;
                 height: 0;
                 min-height: 0;
         }

 }}}


 Which is covered by:
 {{{
 .metabox-holder.columns-1 .postbox-container .empty-container,
 .columns-2 #postbox-container-3 .empty-container,
 .columns-2 #postbox-container-4 .empty-container,
 .columns-3 #postbox-container-4 .empty-container {
         border: 0 none;
         height: 0;
         min-height: 0;
 }

 }}}

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/21947#comment:6>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software