[wp-trac] [WordPress Trac] #23042: Post edit page may become almost unusable and textarea resize not saved

[WordPress Trac]

#23042: Post edit page may become almost unusable and textarea resize not saved
--------------------------+------------------------------
 Reporter:  kinderr@…     |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Editor        |     Version:  3.5
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |
--------------------------+------------------------------
Description changed by SergeyBiryukov:

Old description:

> Follow-up testing to Ticket #22708 and patches
> http://core.trac.wordpress.org/changeset/23016
> http://core.trac.wordpress.org/changeset/23017
>
> I installed the new versions of:
> /wp-admin/js/post.js (23016) and
> /wp-includes/class-wp-editor.php (23017)
>
> on my Wordpress 3.5 server. The problem still exists that the post editor
> window is forced to 5000 pixels tall because the wp_usermeta -> wp_user-
> settings -> ed_size value is being set to
> ed_size=310566666&editor=tinymce&mfold=f or other extremely large value
> with FireFox 17.0.1 and Chrome 23.0.1271.97 m. The ed_size bad cookie
> value triggers the patch code logic to set the post editor to 5000 lines.
>
> My Win7 screen resolution is 1920w x 1080h which means the editor is
> around 5 screens tall. This is almost as bad as the practically infinite
> bug value. Manually resizing the post editor height by dragging the lower
> right pane control will not survive a post update and the post editor
> resets to 5000 pixels high. This makes the editor tool bar practically
> inaccessible and a big drag on usability. See
> http://wordpress.org/support/topic/the-option-to-change-the-size-of-
> editor-is-missing-how-to-change-the-size
>
> As a temporary workaround, I modified line 704 in post.js to 500 pixels:
> if ( height > 50 && height < 500 && height != getUserSetting( 'ed_size' )
> )
> setUserSetting( 'ed_size', height );
> }
>
> and lines 74 & 75 in class-wp-editor.php to 500 pixels:
> if ( $set['editor_height'] < 50 )
>   $set['editor_height'] = 50;
> elseif ( $set['editor_height'] > 500 )
>   $set['editor_height'] = 500;
>
> which is a comfortable post editor size (my personal preference) that is
> "sticky".
>
> In summary, the 5000 pixel sanity logic for the post editor size doesn't
> fix the underlying ed_size blowup.

New description:

 Follow-up testing to Ticket #22708 and patches [23016]
 [23017]

 I installed the new versions of:
 /wp-admin/js/post.js (23016) and
 /wp-includes/class-wp-editor.php (23017)

 on my Wordpress 3.5 server. The problem still exists that the post editor
 window is forced to 5000 pixels tall because the wp_usermeta -> wp_user-
 settings -> ed_size value is being set to
 ed_size=310566666&editor=tinymce&mfold=f or other extremely large value
 with FireFox 17.0.1 and Chrome 23.0.1271.97 m. The ed_size bad cookie
 value triggers the patch code logic to set the post editor to 5000 lines.

 My Win7 screen resolution is 1920w x 1080h which means the editor is
 around 5 screens tall. This is almost as bad as the practically infinite
 bug value. Manually resizing the post editor height by dragging the lower
 right pane control will not survive a post update and the post editor
 resets to 5000 pixels high. This makes the editor tool bar practically
 inaccessible and a big drag on usability. See
 http://wordpress.org/support/topic/the-option-to-change-the-size-of-
 editor-is-missing-how-to-change-the-size

 As a temporary workaround, I modified line 704 in post.js to 500 pixels:
 {{{
 if ( height > 50 && height < 500 && height != getUserSetting( 'ed_size' )
 )
 setUserSetting( 'ed_size', height );
 }
 }}}
 and lines 74 & 75 in class-wp-editor.php to 500 pixels:
 {{{
 if ( $set['editor_height'] < 50 )
   $set['editor_height'] = 50;
 elseif ( $set['editor_height'] > 500 )
   $set['editor_height'] = 500;
 }}}
 which is a comfortable post editor size (my personal preference) that is
 "sticky".

 In summary, the 5000 pixel sanity logic for the post editor size doesn't
 fix the underlying ed_size blowup.

--

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/23042#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software