[wp-trac] [WordPress Trac] #22856: Twenty Twelve upgrade issues

[WordPress Trac]

#22856: Twenty Twelve upgrade issues
-----------------------------+--------------------
 Reporter:  nacin            |       Owner:
     Type:  defect (bug)     |      Status:  new
 Priority:  normal           |   Milestone:  3.5.1
Component:  Upgrade/Install  |     Version:
 Severity:  normal           |  Resolution:
 Keywords:                   |
-----------------------------+--------------------

Comment (by nacin):

 Okay, so:

 When preparing api.wordpress.org for release, I missed that the
 new_bundled variable was not populated with 3.5. It remained at 3.2. You
 can see this variable here: http://api.wordpress.org/core/version-
 check/1.6/?debug. (I've added this to our release checklist in two
 different places to avoid us missing this in the future.)

 When that occurred, Core_Upgrader::upgrade() chose the no-content package.
 This meant that the downloaded zip would not have any themes or plugins in
 it. Normally, this would be fine, and someone could just go over to theme-
 install.php and install Twenty Twelve from there.

 But, they couldn't, because the "Copy New bundled plugins & themes"
 section of update_core() in wp-admin/includes/update-core.php loops
 through $_new_bundled_files and does a copy(), which manages to create an
 empty directory (but nothing else, as there was nothing else to copy).

 So then what happens is the theme shows as broken — it's a directory
 without a stylesheet. But, wp_update_themes() does not check broken
 themes. (It calls `wp_get_themes()` rather than `wp_get_themes( array(
 'errors' => null ) )`.) So, core thinks it is up to date, which means you
 can't install/update it. It's broken, which means you can't delete it.
 Overall, a bit of a mess. I think we can make some of this experience
 better in 3.6.

 Here's an initial Hotfix that allows Twenty Twelve to updated to 1.1 if it
 exists but is a broken theme:
 http://plugins.trac.wordpress.org/changeset/637271 (and
 http://plugins.trac.wordpress.org/changeset/637297).

 (Note: We had temporarily released 1.1.1 back when I didn't realize it
 wouldn't be updatable. To avoid hitting everyone with an update notice, I
 rolled it back. 1.1 is now current.)

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/22856#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software