[wp-trac] [WordPress Trac] #22790: Duplicating Embed-Codes

[WordPress Trac]

#22790: Duplicating Embed-Codes
------------------------------+-----------------------
 Reporter:  Bichareh          |       Owner:  ryan
     Type:  defect (bug)      |      Status:  reopened
 Priority:  highest omg bbq   |   Milestone:  3.5
Component:  TinyMCE           |     Version:  trunk
 Severity:  blocker           |  Resolution:
 Keywords:  has-patch commit  |
------------------------------+-----------------------
Changes (by koopersmith):

 * keywords:  has-patch => has-patch commit


Comment:

 I've looked through MCE in 3.5 and 3.4 and the various code paths, and
 this appears to be the correct fix. Allowing all children is too broad,
 but registering the embed tag without adding it as a child causes large
 amounts of breakage when the TinyMCE media plugin reads an object.

 To quote azaozz from IRC:
 > It works in 3.4 as the <embed> tag is not mentioned as being allowed
 child of any other tag, so the check skips it.

 The TinyMCE HTML5 schema adds the embed tag, so things begin breaking.
 This fixes them. +1 for commit.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/22790#comment:35>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software