[wp-trac] [WordPress Trac] #22839: Spinners don't show up in .sidebar-name

[WordPress Trac]

#22839: Spinners don't show up in .sidebar-name
-------------------------------------------------+-------------------------
 Reporter:  cdog                                 |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
Component:  UI                                   |  Review
 Severity:  normal                               |     Version:  trunk
 Keywords:  has-patch needs-testing reporter-    |  Resolution:
  feedback                                       |
-------------------------------------------------+-------------------------

Comment (by cdog):

 Replying to [comment:13 helenyhou]:
 > Oh, I get the same result if you run .show() yourself in the console.
 But I'm not seeing it as broken in core. I'm on 17.0.1 on OSX.
 You are right. It's my fault. Should be more carefully next time.

 saveOrder does use:
 {{{
 $('#' + sb).closest('div.widgets-holder-
 wrap').find('.spinner').css('display', 'inline-block');
 }}}
 and save:
 {{{
 $('.spinner', widget).show();
 }}}
 and works just well.

 Got in error by myself while switching from .ajax-feedback to .spinner.
 It's confusing because of the two different methods used to show the
 spinner. Who knows where my mind was.

 Still, applying the patch would make possible to use:
 {{{
 $('#' + sb).closest('div.widgets-holder-wrap').find('.spinner').show();
 }}}
 instead of:
 {{{
 $('#' + sb).closest('div.widgets-holder-
 wrap').find('.spinner').css('display', 'inline-block');
 }}}

 Thanks for taking your time.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/22839#comment:14>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software