[wp-trac] [WordPress Trac] #22839: Spinners don't show up in .sidebar-name

[WordPress Trac]

#22839: Spinners don't show up in .sidebar-name
-------------------------------------+------------------------------
 Reporter:  cdog                     |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  UI                       |     Version:  trunk
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+------------------------------
Changes (by cdog):

 * cc: catalin.dogaru@… (added)
 * keywords:  needs-patch => has-patch needs-testing


Comment:

 [http://api.jquery.com/show/ .show()] restores the display property to
 whatever it was initially. Because the spinner is a span element, that
 value will be inline which causes the width and height properties to be
 ignored conform to the [http://www.w3.org/TR/CSS1/#inline-elements CSS
 Level 1] specifications.

 The spinner is displayed in .widget-title because the float property is
 used which establishes a new [http://colinaarts.com/articles/the-magic-of-
 overflow-hidden/ block formatting context], while in .sidebar-none float
 is set to none.

 One solution would be to use [http://api.jquery.com/css/ .css()] instead
 of [http://api.jquery.com/show/ .show()] to set the display property to
 inline-block. Or to make the element to establish a new BFC which requires
 less changes in code.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/22839#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software