[wp-trac] [WordPress Trac] #22828: Remove Duplicate Array Check

WordPress Trac noreply at wordpress.org
Sat Dec 8 18:52:42 UTC 2012


#22828: Remove Duplicate Array Check
--------------------------+------------------------------
 Reporter:  miqrogroove   |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  Performance   |     Version:  3.4.2
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------------------
Changes (by miqrogroove):

 * keywords:   => has-patch


Comment:

 Explanation of miqro-22828.2.diff :

 An additional operation is saved because if isset( $from_api->updates )
 then the function should proceed normally and this implies
 !empty($from_api).  On the other hand, if !isset( $from_api->updates )
 then the function should return to the caller and there is no reason to
 check if ( empty($from_api) ).

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/22828#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list