[wp-trac] [WordPress Trac] #22824: multi_resize can cause fatal if individual _save(s) fail

WordPress Trac noreply at wordpress.org
Sat Dec 8 05:50:26 UTC 2012


#22824: multi_resize can cause fatal if individual _save(s) fail
-----------------------------+--------------------------
 Reporter:  dh-shredder      |       Type:  defect (bug)
   Status:  new              |   Priority:  normal
Milestone:  Awaiting Review  |  Component:  Media
  Version:  trunk            |   Severity:  major
 Keywords:  has-patch        |
-----------------------------+--------------------------
 `multi_resize` is not properly checking for `WP_Error` after a save before
 dereferencing the metadata returned from _save().  This can cause a fatal
 error (due to dereferencing a `WP_Error`) if one of the individual saves
 fails.

 This is a regression to the previous behavior in 3.4.2

 Patch attached fixes this by moving the array access/unset into the `!
 is_wp_error()` check.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/22824>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list