[wp-trac] [WordPress Trac] #22790: Duplicating Embed-Codes

WordPress Trac noreply at wordpress.org
Fri Dec 7 11:46:22 UTC 2012


#22790: Duplicating Embed-Codes
--------------------------+---------------------
 Reporter:  Bichareh      |       Owner:  ryan
     Type:  defect (bug)  |      Status:  closed
 Priority:  normal        |   Milestone:  3.5
Component:  TinyMCE       |     Version:  trunk
 Severity:  major         |  Resolution:  fixed
 Keywords:  has-patch     |
--------------------------+---------------------

Comment (by nacin):

 After a long work session in IRC, it was determined that addValidElements
 was insufficient for new elements (acronym, strike, etc.), because it did
 not set those elements to be allowed children for all other elements. This
 is a problem because to fix it, we'd need to call addValidChildren for
 essentially every element. The elements would still work even if they were
 not allowed; per Spocke they would be treated as custom elements and kind
 of like spans. But tinymce.activeEditor.schema.isValidChild would return
 false, and we didn't want to get into the ramifications of that.

 At that point, we decided to go with Koop's straightforward duck punch.
 [23120], and bumpbot in [23121]. The wp-tinymce.js.gz file now includes a
 minified version of wp-includes/js/tinymce/wp-tinymce-schema.js
 immediately after core, and before plugins. That will allow our version of
 Schema.js to replace theirs.

 Nice work, everyone.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/22790#comment:31>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list