[wp-trac] [WordPress Trac] #22790: Duplicating Embed-Codes

[WordPress Trac]

#22790: Duplicating Embed-Codes
--------------------------+-----------------------
 Reporter:  Bichareh      |       Owner:  ryan
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:  3.5
Component:  TinyMCE       |     Version:  trunk
 Severity:  major         |  Resolution:
 Keywords:  has-patch     |
--------------------------+-----------------------
Changes (by nacin):

 * keywords:   => has-patch


Comment:

 Three approaches here:
  * I manually went into getHTML5 and added elements, attributes, and
 children. (You can see this in [attachment:22790.getHTML5.diff].)
  * koopersmith wrote a script to merge getHTML5 and getHTML4. You can see
 this in [attachment:22790.schema.debug.diff]. Look for things like
 "WordPress," "sane," "nacin," and "Koop".
  * azaozz added everything in the TinyMCE plugin.

 Then, Koop used his script to check both my work and azaozz's work. There
 were a few issues in my work that we resolved
 [attachment:22790.schema.2.diff] includes those changes).

 azaozz's patch is missing `lang` and `xml:lang` in a number of places.
 (Which I don't really care about... should we?)

 Additionally, azaozz's patch ignores children. (How could you?!) It only
 adds elements and attributes. That means that in azaozz's patch,
 tinymce.activeEditor.schema.isValidChild( 'div', 'big' ) returns false.
 For me and koop, it returns true.

 But, it seems like TinyMCE doesn't care about children validness. (Insert
 parental joke here?) `<div><big>Big</big></div>` works as long as `<big>`
 is registered with addValidElements, even if it is missing from div's
 children. Which makes us all wonder if it is a bug, an incomplete API, or
 just something we're missing.

 azaozz is now pinging TinyMCE's Spocke to discuss. Assuming we can just
 ignore the plight of the children, I am +1 on azaozz's patch, primarily
 because his results has been backed up by two other methods and a lot of
 manpower, and secondarily since we've already been doing exactly that all
 release, for other elements and attributes.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/22790#comment:27>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software