[wp-trac] [WordPress Trac] #22740: 3.5 Media: "From URL" doesn't provide any feedback on error
WordPress Trac
noreply at wordpress.org
Tue Dec 4 22:40:21 UTC 2012
#22740: 3.5 Media: "From URL" doesn't provide any feedback on error
------------------------------+------------------------------
Reporter: Viper007Bond | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Media | Version: trunk
Severity: normal | Resolution:
Keywords: has-patch commit |
------------------------------+------------------------------
Comment (by nacin):
Replying to [comment:6 Viper007Bond]:
> Replying to [comment:5 johnbillion]:
> > 3.4 shows a red X next to the URL input field if it doesn't get a 200
when it tries to fetch the image.
>
> Bonus: no new strings.
Right, but we're using that same check to determine if it is an Image. We
have no good way of determining if it is not an image (but is, and is
failing), or if it is not an image (and really isn't an image).
Can you please test [attachment:22740.diff]? What it does is automatically
assume that .jpg, .png, and .gif are images, so the fields may be shown,
even if it can't load it.
If we wanted to top this off, we can probably also add back a red X if it
thinks it is an image based on the extension (which will show the fields)
but fetching it doesn't work (which will tell the user something is
wrong).
--
Ticket URL: <http://core.trac.wordpress.org/ticket/22740#comment:7>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list