[wp-trac] [WordPress Trac] #21758: Do not require a file in comments_template()

WordPress Trac wp-trac at lists.automattic.com
Fri Aug 31 20:29:35 UTC 2012


#21758: Do not require a file in comments_template()
-------------------------+------------------------------
 Reporter:  mattonomics  |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  Comments     |     Version:  3.4.1
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |
-------------------------+------------------------------

Comment (by nacin):

 Rather than a new parameter, I think this makes the most sense as a
 separate function.

 comments_template() can remain for template inclusion purposes, but a new
 function should handle setup. It might make the most sense as a method on
 WP_Query, such as get_comments() to match get_posts().

 Things like set_query_var() would need to become $query->set() to be
 agnostic for any WP_Query object.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/21758#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list