[wp-trac] [WordPress Trac] #21685: Twenty Twelve: Code simplifications (and one tabs > spaces issue)
WordPress Trac
wp-trac at lists.automattic.com
Sat Aug 25 10:07:41 UTC 2012
#21685: Twenty Twelve: Code simplifications (and one tabs > spaces issue)
---------------------------+------------------------------
Reporter: obenland | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Bundled Theme | Version:
Severity: minor | Resolution:
Keywords: has-patch |
---------------------------+------------------------------
Comment (by obenland):
[attachment:21685-indentation.diff]: Makes HTML indentation consistent
across all template files. Moves to if-endif syntax in `homepage.php` for
consistency.
[attachment:21685-sidebars.diff]: Consistently calls sidebars with just
the ID. Removes unnecessary closing/opening php tags and makes in-code
comment consistent with how it is done in other parts of the Theme
[attachment:21685-comments.diff]: Removes unnecessary closing/opening php
tags and indentation
[attachment:21685-customizer.diff]: No need to put the selector in a
variable as it will be called only once anyway
[attachment:21685-navigation.diff]: Tabs > spaces
[attachment:21685-theme-options.diff]: No need for extra trues and falses,
the conditional already returns the desired result. Capability is set to
`'edit_theme_options'` by default
--
Ticket URL: <http://core.trac.wordpress.org/ticket/21685#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list