[wp-trac] [WordPress Trac] #21562: Twenty Twelve: improve navigation to be mobile-first and not rely on JS for hiding and showing
WordPress Trac
wp-trac at lists.automattic.com
Thu Aug 23 08:35:21 UTC 2012
#21562: Twenty Twelve: improve navigation to be mobile-first and not rely on JS for
hiding and showing
---------------------------+------------------
Reporter: cfinke | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.5
Component: Bundled Theme | Version:
Severity: normal | Resolution:
Keywords: |
---------------------------+------------------
Comment (by obenland):
Replying to [comment:29 Jayjdk]:
> Doesn't that patch assume that the ID of the menu is `menu-menu` (`var
menu = document.getElementById( 'menu-menu' )`)?
>
> That is not always the case. If I call my menu `foo`, the ID will be
`menu-foo`
That's right. The patch is a work in progress, as it also lacks support
for `wp_page_menu()`.
Which brings up a whole different topic of having to add a callback to
`'wp_page_menu'` to wrap it with an element with an id, to be able to
target it with JS.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/21562#comment:30>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list