[wp-trac] [WordPress Trac] #21507: Hide charset setting for new installs

[WordPress Trac]

#21507: Hide charset setting for new installs
----------------------------+-----------------------
 Reporter:  nacin           |       Owner:  nacin
     Type:  task (blessed)  |      Status:  reopened
 Priority:  normal          |   Milestone:  3.5
Component:  Charset         |     Version:
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |
----------------------------+-----------------------
Changes (by SergeyBiryukov):

 * keywords:   => has-patch
 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 [21467] introduced a bug: if you go to Reading Settings and click Save
 Changes, the charset gets overwritten with an empty string in `wp-
 admin/options.php` (since it's still in `$whitelist_options`): [[BR]]
 http://core.trac.wordpress.org/browser/tags/3.4.1/wp-
 admin/options.php#L137

 As far as I can see, there's no way to output arbitrary hidden fields
 using the Settings API.

 [attachment:21507.patch] moves the check to the beginning of the form and
 adds hidden `blog_charset` field right after `settings_fields()` if the
 charset is UTF-8.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/21507#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software