[wp-trac] [WordPress Trac] #21616: add-textdomain doesn't conform to WP coding standards

WordPress Trac wp-trac at lists.automattic.com
Fri Aug 17 14:40:43 UTC 2012


#21616: add-textdomain doesn't conform to WP coding standards
--------------------------+----------------------------
 Reporter:  groovecoder   |       Owner:
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:  WordPress.org
Component:  I18N          |     Version:
 Severity:  normal        |  Resolution:
 Keywords:                |
--------------------------+----------------------------

Comment (by groovecoder):

 I like the idea, and I tried it, but it has too many knock-on effects that
 cause new violations on otherwise well-formatted code like empty array
 declarations:
 {{{
 $urls = array( );
 }}}

 and multi-line function calls:

 {{{
 $body = wp_remote_retrieve_body(
     wp_remote_get(
 }}}

 We could add conditionals, but that starts to add too much noise to the
 code. This script's purpose is just to add text domains - but it shouldn't
 introduce new coding violations so that a dev who took their time to clean
 the code before adding text domains doesn't have more work to do.

 Dev's cold and should use [https://github.com/scribu/wp-phptidy scribu's
 script] separately to clean code.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/21616#comment:12>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list