[wp-trac] [WordPress Trac] #21568: Update Services_JSON External Library
WordPress Trac
wp-trac at lists.automattic.com
Mon Aug 13 20:38:11 UTC 2012
#21568: Update Services_JSON External Library
--------------------------------+-----------------------------
Reporter: bpetty | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: External Libraries | Version: 3.4.1
Severity: normal | Keywords: has-patch
--------------------------------+-----------------------------
This is an update of Services_JSON used both for compatibility for pre-
PHP-5.2, and also for hosts that have explicitly (and sickeningly)
disabled json_encode() / json_decode().
Current version included in WordPress is 1.0.1. This updates to version
1.0.3 from upstream.
There's only one single non-upstream change that is included here, and
it's a simple include guard, see #11827.
The following bugs were addressed with this update:
1. http://pear.php.net/bugs/bug.php?id=16908 - When locale was set, and it
changed the way numbers are formated, the output for floats was broken.
2. http://pear.php.net/bugs/bug.php?id=17515 - Handle mbstring overloading
of strlen().
3. http://pear.php.net/bugs/bug.php?id=17921 - Long strings cause problems
for parser.
One last note here...
The only other non-upstream changes made to the library within WP core
previously were just whitespace changes. In the future, it would be nice
to know that whitespace changes should *not* touch 3rd party libraries
since 1) they will always have their own coding guidelines, and 2) it
makes it difficult to see actual upstream and non-upstream changes between
WP core updates.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/21568>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list