[wp-trac] [WordPress Trac] #21480: Twenty Twelve: use FitVids to resize videos in small screens

[WordPress Trac]

#21480: Twenty Twelve: use FitVids to resize videos in small screens
---------------------------+------------------
 Reporter:  andyadams      |       Owner:
     Type:  enhancement    |      Status:  new
 Priority:  normal         |   Milestone:  3.5
Component:  Bundled Theme  |     Version:
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |
---------------------------+------------------

Comment (by lancewillett):

 Replying to [comment:11 obenland]:
 > @lancewillett: Only found a syntax error with a comma missing after
 `'scribd.com'`. Do we really need to remove width and height? I found it
 working in my tests without the entire replace part. We could then just
 check the whitelist and wrap the html in the if statement. Leaves us with
 only one return. I could be wrong on that, though.

 Hmm, it's worth exploring removing the width/height checks. I'll test some
 more. Good catch on the missing comma, saw that after I put up my patch.

 > I don't see why this has to be "fixed" in the first place. And I don't
 like the overhead of either solution for such a (in my eyes) small gain.

 Heh, I think it's a better experience overall to see the video in the
 correct size before it plays.

 Your point on tracking new embed sources in core is valid -- ideally this
 HTML wrapper would come from core, not the theme. That way any theme can
 benefit from the extra hook.

 I feel the same way about fitvids, it should be on the platform (core,
 video providers, or in browsers natively).

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/21480#comment:13>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software