[wp-trac] [WordPress Trac] #21480: Twenty Twelve: use FitVids to resize videos in small screens

[WordPress Trac]

#21480: Twenty Twelve: use FitVids to resize videos in small screens
---------------------------+------------------
 Reporter:  andyadams      |       Owner:
     Type:  enhancement    |      Status:  new
 Priority:  normal         |   Milestone:  3.5
Component:  Bundled Theme  |     Version:
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |
---------------------------+------------------

Comment (by obenland):

 @lancewillett: Only found a syntax error with a comma missing after
 `'scribd.com'`. Do we really need to remove width and height? I found it
 working in my tests without the entire replace part. We could then just
 check the whitelist and wrap the html in the if statement. Leaves us with
 only one return. I could be wrong on that, though.

 [[BR]]

 On the issue in general:
 There will never be a holistic solution either way.

 * Apart from the extra request, Fitvids only supports four core embed
 providers out of the box.

 * With PHP/CSS: Providers added through the `'oembed_providers'` filter
 won't get the treatment. And while adding a filter to the whitelist in
 `twentytwelve_modify_embed_output()` might help, we'll still have to keep
 the provider whitelist up-to-date with the default providers in core, once
 it's in.

 I don't see why this has to be "fixed" in the first place. And I don't
 like the overhead of either solution for such a (in my eyes) small gain.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/21480#comment:11>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software