[wp-trac] [WordPress Trac] #11286: Normal User Input Causes Status 500

[WordPress Trac]

#11286: Normal User Input Causes Status 500
------------------------------------+-----------------------------
 Reporter:  miqrogroove             |       Owner:
     Type:  defect (bug)            |      Status:  new
 Priority:  normal                  |   Milestone:  Future Release
Component:  Comments                |     Version:  2.8.4
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch commit early  |
------------------------------------+-----------------------------
Changes (by bpetty):

 * cc: bpetty (added)


Comment:

 Replying to [comment:5 miqrogroove]:
 > There is no relevant error at the HTTP layer.  Just as you would not set
 status 403 for comment moderation, in this case the client and server have
 done nothing wrong.  The server should return OK for the request.

 This is entirely correct. Form validation errors (even duplicate comment
 rejections) should always return 200. It's the body of the request that is
 responsible for giving the response whether it's valid or not.

 The only valid case I can see for anything other than 200 here is if
 authentication was required for submitting comments, and the client wasn't
 authenticated (or authenticated with an account without proper
 permissions), so just 403. This is only because in that case, the form
 shouldn't even be processed, it's the actual POST request being rejected,
 not the form values.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/11286#comment:36>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software