[wp-trac] [WordPress Trac] #20506: Undefined variable $screen_layout_columns when filtering out screen options
WordPress Trac
wp-trac at lists.automattic.com
Sun Apr 22 17:33:21 UTC 2012
#20506: Undefined variable $screen_layout_columns when filtering out screen options
------------------------------------+------------------------------
Reporter: griffinjt | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Warnings/Notices | Version: 3.3.1
Severity: normal | Resolution:
Keywords: has-patch dev-feedback |
------------------------------------+------------------------------
Comment (by griffinjt):
Yes, it needs to be outside out that method.
Actually, the whole method needs to be separated into two methods: one
with the logic and the other with the output. I've split
`WP_Screen::render_screen_layout()` into the former and
`WP_Screen::get_screen_layout()`.
Since it's separated, I've called `WP_Screen::get_screen_layout()` within
the `render_screen_meta` method, just before the check is made to see if
the screen options should be output.
Needs some testing, but it has worked fine for me in all my tests.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/20506#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list