[wp-trac] [WordPress Trac] #20492: Improve submit_button() (was: Switch submit_button()'s parameters to an associative array)

[WordPress Trac]

#20492: Improve submit_button()
-----------------------------+------------------------------
 Reporter:  johnbillion      |       Owner:
     Type:  feature request  |      Status:  new
 Priority:  low              |   Milestone:  Awaiting Review
Component:  General          |     Version:  3.4
 Severity:  normal           |  Resolution:
 Keywords:                   |
-----------------------------+------------------------------
Changes (by johnbillion):

 * keywords:  has-patch needs-testing =>
 * type:  enhancement => feature request


Comment:

 Okay I've changed my mind on this. Clearly `submit_button()`'s default
 parameters are not appropriate 90% of the time it's used. Going through
 core to patch the calls to `submit_button()` I can see that the 'wrap'
 parameter is set to 'false' most of the time, and the 'type' parameter is
 set to 'button' or 'secondary' most of the time.

 We'd be better off introducing a couple of new submit button functions
 (one for each button type) and deprecating `submit_button()`.

 I don't really want to waste any more time on the issue though, so someone
 else can take this on if they like.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/20492#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software