[wp-trac] [WordPress Trac] #20369: HTML captions: Using double quotes for attributes breaks the ouput
WordPress Trac
wp-trac at lists.automattic.com
Fri Apr 6 19:37:45 UTC 2012
#20369: HTML captions: Using double quotes for attributes breaks the ouput
--------------------------+---------------------
Reporter: ocean90 | Owner: azaozz
Type: defect (bug) | Status: closed
Priority: normal | Milestone: 3.4
Component: Shortcodes | Version: 3.4
Severity: normal | Resolution: fixed
Keywords: has-patch |
--------------------------+---------------------
Comment (by duck_):
Replying to [comment:6 azaozz]:
> In [20376]:
> {{{
> #!CommitTicketReference repository="" revision="20376"
> Fix second callback when filtering caption text for shortcode, props
SergeyBiryukov, fixes #20369
> }}}
That code can be simplified to remove the isset() check. The function will
not be called unless there was a match which means that key 0 will be set.
See [attachment:20369.simplify.diff 20369.simplify.diff]. I also changed
the parameter to `$matches` since it's not actually a string.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/20369#comment:10>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list