[wp-trac] [WordPress Trac] #18548: Add a better option for <title> tags
WordPress Trac
wp-trac at lists.automattic.com
Wed Apr 4 10:23:43 UTC 2012
#18548: Add a better option for <title> tags
------------------------------------------------+--------------------------
Reporter: joostdevalk | Owner: joostdevalk
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting
Component: Template | Review
Severity: normal | Version: 3.3
Keywords: has-patch dev-feedback needs-codex | Resolution:
------------------------------------------------+--------------------------
Comment (by johnbillion):
Thanks for the thorough explanation of your patch Chris. I really like
this approach. The original patch by Yoast didn't make it a lot easier for
plugins to avoid stepping on each other's toes. Using an associative array
solves this (I use a similar system for breadcrumb components in my theme
framework).
The only major problem I can see with the patch is that the
`pre_wp_title_tag` filter is ripe for abuse. By allowing plugins to hook
into this filter we actually undo all the other hard work that allows the
separate title components to be filtered.
If one single plugin on your site decides to use the `pre_wp_title_tag`
filter then we're back at square one and all our hard work is for nothing.
The main `title_tag_filter` filter hasn't run at this point, so changes to
the content title made by another plugin is not going to be taken into
account. I'd like to recommend removing the `pre_wp_title_tag` filter.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/18548#comment:88>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list