[wp-trac] [WordPress Trac] #18823: Pass $post_id as second argument to delete_postmeta action

WordPress Trac wp-trac at lists.automattic.com
Fri Sep 30 14:38:00 UTC 2011


#18823: Pass $post_id  as second argument to delete_postmeta action
-------------------------+------------------------------
 Reporter:  Vynce        |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  Awaiting Review
Component:  General      |     Version:  3.2
 Severity:  minor        |  Resolution:
 Keywords:               |
-------------------------+------------------------------

Comment (by duck_):

 I think that the extra values weren't passed for delete_postmeta as this
 action is used in two different circumstances. delete_meta and
 delete_post_meta_by_key act on different information. The former takes a
 specific meta id which is tied to one object, the latter can delete meta
 from multiple objects. See #10750 and [11968] for the original
 introduction of the action. We might want to think about this before
 changing something. However, they are already inconsistent in what type of
 data gets passed...

 The delete(d)_postmeta actions are also passed arrays and integers
 inconsistently (delete_meta vs. delete_post_meta_by_key again). Though
 this isn't new it could be fixed, but I'm unsure how this may affect back
 compat.

 See #18825 for a ticket I opened about backwards incompatibility in these
 actions in 3.3.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/18823#comment:1>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list