[wp-trac] [WordPress Trac] #17895: delete_post_thumbnail()
WordPress Trac
wp-trac at lists.automattic.com
Thu Sep 22 09:51:46 UTC 2011
#17895: delete_post_thumbnail()
--------------------------------------------------+-----------------------
Reporter: nacin | Owner:
Type: enhancement | Status: assigned
Priority: normal | Milestone: 3.3
Component: Post Thumbnails | Version:
Severity: normal | Resolution:
Keywords: has-patch needs-testing dev-feedback |
--------------------------------------------------+-----------------------
Comment (by CoenJacobs):
Replying to [comment:10 duck_]:
>
> 17895.diff. Changed it to return the return value of `delete_post_meta`.
>
> I'm a bit unsure about returning false if there's no post, but returning
true if there's a post with no thumbnail. Seems to me that both cases
should return the same? Otherwise should be good :)
Sounds good to me.
Returning false when the delete isn't executed because of no set value in
the meta is a choice indeed. Doesn't delete_post_meta (and thus
delete_metadata() ) return false too, if there are no records to delete?
--
Ticket URL: <http://core.trac.wordpress.org/ticket/17895#comment:11>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list