[wp-trac] [WordPress Trac] #18723: Image Editing does not handle failures gracefully

[WordPress Trac]

#18723: Image Editing does not handle failures gracefully
--------------------------+-------------------------
 Reporter:  westi         |      Owner:  azaozz
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  3.3
Component:  Media         |    Version:  3.2
 Severity:  major         |   Keywords:  needs-patch
--------------------------+-------------------------
 The Image Editing tools in the admin do not handle failures gracefully.

 For example if loading an image / rotating and image fails and returns a
 failure instead of an image you end up with a spinning wheel of failure.

 To reproduce:

  * Upload an image
  * Choose to edit it to get to the crop, rotate, resize options.
  * Edit 'stream_preview_image' in 'wp-admin/includes/image-edit.php' to
 always return false.
  * Now try an rotation. Notice the spinner never stops spinning.

 This is because the javascript doesn't register an 'error' handler on the
 img but only a load handler so when WP fails to return an image we don't
 handle the error gracefully.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/18723>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software