[wp-trac] [WordPress Trac] #13774: Theme installer should support child themes

[WordPress Trac]

#13774: Theme installer should support child themes
---------------------------------+-----------------------
 Reporter:  westi                |       Owner:  nacin
     Type:  task (blessed)       |      Status:  accepted
 Priority:  normal               |   Milestone:  3.3
Component:  Upgrade/Install      |     Version:  3.0
 Severity:  normal               |  Resolution:
 Keywords:  has-patch 3.3-early  |
---------------------------------+-----------------------

Comment (by dd32):

 > attachment [attachment:13774.2.diff]  added
  * My stab at implementing the parent theme installation.
  * Doesnt handle themes_api() failing on the parent installation
  * Doesnt handle parent theme installation failing (see screenshot) - It
 shouldn't offer activation/preview in that case.

 I've taken the approach of having the parent themes installation details
 being included in the "steps" rather than having a duplicated header as in
 Otto's patch, this makes it less obvious that 2 themes are being
 installed, but also brings a few issues where the messages area easy to
 mistake for the child themes installation.

 One suggestion I've got for that is something like this:
 {{{
 Installing Theme: Journalist 1.9 <-- page header

 Downloading install package from http://wordpress.org/...zip…
 Unpacking the package…
 Installing the theme…
 Successfully installed the theme Journalist 1.9.

 Preparing to install the parent theme The Common Blog 1.5.3… <-- Same font
 size as the lines above and below
 Downloading install package from http://wordpress.org/..zip…
 Unpacking the package…
 Installing the theme…
 Successfully installed the parent theme The Common Blog 1.5.3.

 ..Actions on child theme here...
 }}}


 > attachment [attachment:child-theme-install.png]  added
  * Top: Installing a child theme, automatically installing the parent
 (Note: The above patch is forcing installation of that "parent" theme for
 all theme installs)
  * Bottom: Installing a child theme, when the parent is already installed.

 > attachment child-theme-install-parent-fail.png  added
  * An example of the Child theme installing whilst the parent installation
 fails.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/13774#comment:17>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software