[wp-trac] [WordPress Trac] #18047: Add edit link to confirmation page for new network site
WordPress Trac
wp-trac at lists.automattic.com
Sun Sep 18 23:45:09 UTC 2011
#18047: Add edit link to confirmation page for new network site
---------------------------+-----------------------
Reporter: vegasgeek | Owner: PeteMall
Type: enhancement | Status: assigned
Priority: normal | Milestone: 3.3
Component: Network Admin | Version:
Severity: normal | Resolution:
Keywords: has-patch |
---------------------------+-----------------------
Changes (by nacin):
* owner: => PeteMall
* status: new => assigned
* type: feature request => enhancement
* milestone: Awaiting Review => 3.3
Comment:
+1. $_GET['site_id'] will need absint() before going directly into a URL
parameter. XSS hole otherwise.
Probably fine as `id` rather than `site_id`.
The 'or' isn't translatable. Probably better to do this:
`sprintf( __( 'Site added. <a href="%1$s">Visit Dashboard</a> or <a
href="%2$s">Edit Site</a>' ), first link, second link )`
--
Ticket URL: <http://core.trac.wordpress.org/ticket/18047#comment:3>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list