[wp-trac] [WordPress Trac] #15473: wp_login action can't deal with alternate auth mechanisms

WordPress Trac wp-trac at lists.automattic.com
Fri Sep 16 12:07:09 UTC 2011


#15473: wp_login action can't deal with alternate auth mechanisms
--------------------------+------------------
 Reporter:  Otto42        |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.3
Component:  Users         |     Version:  3.1
 Severity:  minor         |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------
Changes (by SergeyBiryukov):

 * keywords:  has-patch 3.2-early => has-patch
 * milestone:  Future Release => 3.3


Comment:

 Code reference: http://core.trac.wordpress.org/browser/tags/3.2.1/wp-
 includes/user.php#L53

 Wouldn't `$user` always be a `WP_User` object at this point, since
 `WP_Error` is handled earlier? We can probably skip the check.

 [attachment:15473.patch] passes `$user->user_login` and adds `$user` as a
 second parameter, as suggested in #17085.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/15473#comment:6>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list