[wp-trac] [WordPress Trac] #18598: When "sidebars_widgets" option is malformed, an infinite loop occurs
WordPress Trac
wp-trac at lists.automattic.com
Wed Sep 14 23:03:27 UTC 2011
#18598: When "sidebars_widgets" option is malformed, an infinite loop occurs
--------------------------+------------------
Reporter: Viper007Bond | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 3.3
Component: Widgets | Version: 3.3
Severity: normal | Resolution:
Keywords: has-patch |
--------------------------+------------------
Comment (by lancewillett):
Replying to [comment:9 SergeyBiryukov]:
> Replying to [comment:8 lancewillett]:
> > also removes an extra {{{wp_get_sidebars_widgets()}}} call from inside
{{{retrieve_widgets()}}}
>
> I guess the current logic requires it, unless I'm missing something.
It wasn't in the function until recently, and seems to be redundant. Can
also cause a loop by calling {{{wp_get_sidebars_widgets()}}} from
{{{retrieve_widgets()}}} -- which could call
{{{wp_get_sidebars_widgets()}}} again.
Having the global call for {{{$sidebars_widgets}}} (which your patch
fixes) takes care of it.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/18598#comment:10>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list