[wp-trac] [WordPress Trac] #18006: Twenty Eleven header.php size uses width instead of height

[WordPress Trac]

#18006: Twenty Eleven header.php size uses width instead of height
---------------------------+------------------------------
 Reporter:  RVoodoo        |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  Awaiting Review
Component:  Bundled Theme  |     Version:  3.2
 Severity:  normal         |  Resolution:
 Keywords:  dev-feedback   |
---------------------------+------------------------------
Changes (by SergeyBiryukov):

 * keywords:   => dev-feedback


Comment:

 `/* $src, $width, $height */` refers to what
 `wp_get_attachment_image_src()` returns, not what it takes. However
 there's some inconsistency between Twenty Ten and Twenty Eleven:

 http://core.trac.wordpress.org/browser/tags/3.2.1/wp-
 content/themes/twentyten/header.php#L69
 http://core.trac.wordpress.org/browser/tags/3.2.1/wp-
 content/themes/twentyeleven/header.php#L86

 Twenty Ten checks if `current_theme_supports( 'post-thumbnails' )`, and
 then calls
 `wp_get_attachment_image_src( get_post_thumbnail_id( $post->ID ), 'post-
 thumbnail' )`, which seems to serve the same purpose, but looks a bit
 cleaner.

 Not exactly understand why we attempt to get a 1000x1000 pixels image if
 we only allow 1000x288.

 Would like to see this either fixed or properly explained (and then closed
 as invalid).

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/18006#comment:4>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software