[wp-trac] [WordPress Trac] #18629: Show SVN revision in 'right now' (and footer)
WordPress Trac
wp-trac at lists.automattic.com
Sun Sep 11 01:36:26 UTC 2011
#18629: Show SVN revision in 'right now' (and footer)
----------------------------+------------------------------
Reporter: Ipstenu | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting Review
Component: Administration | Version: 3.3
Severity: normal | Resolution:
Keywords: has-patch |
----------------------------+------------------------------
Comment (by dd32):
Unfortunately I was wrong. Suffixing the version will have issues with
version_compare(), To quote php.net:
> Then it compares the parts starting from left to right. If a part
contains special version strings these are handled in the following order:
'''any string not found in this list < dev < alpha = a < beta = b < RC =
rc < # < pl = p'''. This way not only versions with different levels like
'4.1' and '4.1.2' can be compared but also any PHP specific version
containing development state.
As such, 3.2.1 is Greater than 3.2.1-r12345, and 3.2.1-r12345 is greater
than 3.2.1-RC1. As such, this will be problematic for users who checkout
stable versions, They'll get a update notification for the same version
they're running (if $wp_version is suffixed in version.php, if it was done
anywhere else, it should be fine for updates, but might have issues
elsewhere).
--
Ticket URL: <http://core.trac.wordpress.org/ticket/18629#comment:9>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list