[wp-trac] [WordPress Trac] #18563: Disallowing editing of .php files in the plugin editor blocks access to allowable extensions

[WordPress Trac]

#18563: Disallowing editing of .php files in the plugin editor blocks access to
allowable extensions
----------------------------+------------------------------
 Reporter:  trepmal         |       Owner:
     Type:  defect (bug)    |      Status:  new
 Priority:  normal          |   Milestone:  Awaiting Review
Component:  Administration  |     Version:  2.8
 Severity:  minor           |  Resolution:
 Keywords:  has-patch       |
----------------------------+------------------------------

Comment (by trepmal):

 Fixed nested <p>s and added some handling for plugins that are a single
 php file (such as Hello Dolly).

 If php is not an editable extension and Hello Dolly is selected, it
 previously gave:
 {{{
 Notice: Undefined offset: 0 in /path/to/wp-admin/plugin-editor.php on line
 61
 No such file exists! Double check the name and try again.
 }}}

 I changed it so it instead gives an informative error message. Not sure if
 it would be better to remove plugins with no editable files from the
 'select a plugin to edit' list. Would that be worth the additional work?

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/18563#comment:6>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software