[wp-trac] [WordPress Trac] #18561: Better Way to Insert Things Below Individual Posts
WordPress Trac
wp-trac at lists.automattic.com
Thu Sep 1 20:01:55 UTC 2011
#18561: Better Way to Insert Things Below Individual Posts
-------------------------+------------------------------
Reporter: jane | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: Awaiting Review
Component: General | Version: 3.2.1
Severity: minor | Resolution:
Keywords: |
-------------------------+------------------------------
Comment (by mattwiebe):
Replying to [comment:52 Otto42]:
> Okay, I see that now, but the function you posted is doing it wrong.
You're using the "loop" part name for the contents of the loop, instead of
for the loop itself. This conflicts with twentyten's use of the "loop"
part name, and does essentially what twentyeleven's "content" part name
does.
Sure. Use content instead of loop. That makes sense.
> Also, just wrapping the while ( have_posts() ) : the_post(); ...
endwhile; with some hooks around it seems of limited benefit to me. Theme
authors understand the loop already. Wrapping it isn't really needed.
The "limited" benefit is that we now own the process. We can change it
down the road if need be. This buys us way more future-proofing. Also,
this is even easier for theme authors to understand, whereas trying to
convince them to use {{{get_template_part()}}} is harder. Not only that,
but we need to get them to standardize around the $name part in order for
plugin filtering to even be useful, which would again probably just
require a wrapper function of some type.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/18561#comment:64>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list