[wp-trac] [WordPress Trac] #19080: CPT identifier class name missing from #icon-edit DIV

WordPress Trac wp-trac at lists.automattic.com
Mon Oct 31 17:53:15 UTC 2011


#19080: CPT identifier class name missing from #icon-edit DIV
------------------------------------+-----------------------
 Reporter:  fjarrett                |       Owner:  nacin
     Type:  defect (bug)            |      Status:  accepted
 Priority:  normal                  |   Milestone:  3.3
Component:  UI                      |     Version:  3.3
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |
------------------------------------+-----------------------

Comment (by nacin):

 Per IRC, let's always set ->post_type and ->taxonomy. That renders
 19080.2.diff moot.

 We still like 19080.diff. There was some talk about the method name for
 for_meta_box(). Should it be for_post_type(), or maybe
 convert_post_type()? At first I thought it may be used for more than just
 post types, but the other core values are safe.

 I was curious what other people choose for IDs to their own custom pages
 with meta boxes, but the API doesn't really work unless the $page for
 do_meta_boxes() is the current page. We kept this compatible with post
 types by making the screen IDs for post.php/post-new.php the name of the
 post type.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/19080#comment:17>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list