[wp-trac] [WordPress Trac] #18975: [E_STRICT] menu.php at line 218

[WordPress Trac]

#18975: [E_STRICT] menu.php at line 218
------------------------------------+-----------------------
 Reporter:  arena                   |       Owner:
     Type:  defect (bug)            |      Status:  reopened
 Priority:  normal                  |   Milestone:  3.3
Component:  Menus                   |     Version:  3.3
 Severity:  normal                  |  Resolution:
 Keywords:  dev-feedback has-patch  |
------------------------------------+-----------------------

Comment (by SergeyBiryukov):

 Apparently this doesn't work as expected:
 {{{
 $last_menu_key = array_pop( $last_menu_key = array_keys( $menu ) );
 }}}
 Here's what I see on Posts screen in 3.3-beta2-19067 on PHP 5.3.3 with
 `E_ALL | E_STRICT`:
 {{{
 Strict Standards: Only variables should be passed by reference in wp-
 includes/pomo/mo.php on line 198
 Strict Standards: Only variables should be passed by reference in wp-
 includes/pomo/mo.php on line 198
 Strict Standards: Declaration of Walker_Category_Checklist::start_lvl()
 should be compatible with that of Walker::start_lvl() in wp-
 admin/includes/template.php on line 52
 Strict Standards: Declaration of Walker_Category_Checklist::end_lvl()
 should be compatible with that of Walker::end_lvl() in wp-
 admin/includes/template.php on line 52
 Strict Standards: Declaration of Walker_Category_Checklist::start_el()
 should be compatible with that of Walker::start_el() in wp-
 admin/includes/template.php on line 52
 Strict Standards: Declaration of Walker_Category_Checklist::end_el()
 should be compatible with that of Walker::end_el() in wp-
 admin/includes/template.php on line 52
 Strict Standards: Only variables should be passed by reference in wp-
 admin/includes/menu.php on line 218
 Strict Standards: Non-static method WP_MatchesMapRegex::apply() should not
 be called statically, assuming $this from incompatible context in wp-
 includes/class-wp.php on line 222
 }}}
 [attachment:18975.2.patch] fixes `menu.php` and `mo.php`. Doesn't touch
 the rest for now.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/18975#comment:8>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software