[wp-trac] [WordPress Trac] #18986: Link categories filter doesn't show all categories

[WordPress Trac]

#18986: Link categories filter doesn't show all categories
--------------------------+-----------------------
 Reporter:  ocean90       |       Owner:  ryan
     Type:  defect (bug)  |      Status:  reopened
 Priority:  high          |   Milestone:  3.3
Component:  Taxonomy      |     Version:  3.3
 Severity:  major         |  Resolution:
 Keywords:  has-patch     |
--------------------------+-----------------------

Comment (by nacin):

 Final thought, I think.

 The handler-choosing logic in [18986.3.diff] fails to account for the
 backwards compatibility implications that all custom taxonomies were
 previously used to counting every post, regardless of publish status.

 Should the handler-choosing logic only decide to use the post_term_count
 callback if the only object types are pages, posts, and attachments, and
 defer to the generic handler the moment a custom post type is involved?
 That may be the safest approach, as who knows how the CPT is implemented
 -- the CT counting all items, rather than just published ones, might make
 sense in many situations.

 I think the answer to my question is that custom taxonomies should use the
 generic_term_count callback (as had occurred in 3.2) except for when the
 taxonomy is only attached to one or more of posts/pages/attachments and no
 custom post types, in which case post_term_count is a safe bet.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/18986#comment:17>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software