[wp-trac] [WordPress Trac] #19016: wpdb::_insert_replace_helper() incorrectly quotes prepare placeholders

WordPress Trac wp-trac at lists.automattic.com
Thu Oct 20 16:23:44 UTC 2011


#19016: wpdb::_insert_replace_helper() incorrectly quotes prepare placeholders
--------------------------+----------------------------
 Reporter:  duck_         |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Future Release
Component:  Database      |    Version:  2.8
 Severity:  normal        |   Keywords:  has-patch
--------------------------+----------------------------
 wpdb::_insert_replace_helper() implodes $formatted_fields with "','" this
 produces something like:

 {{{
 INSERT INTO `wp_terms` (`name`,`slug`,`term_group`) VALUES
 ('%s','%s','%d')
 }}}

 and not

 {{{
 INSERT INTO `wp_terms` (`name`,`slug`,`term_group`) VALUES (%s,%s,%d)
 }}}

 This is inherited from wpdb::insert(), see [10724], so marking version as
 2.8 rather than 3.0.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/19016>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list