[wp-trac] [WordPress Trac] #14999: Reject invalid theme.zip uploads

[WordPress Trac]

#14999: Reject invalid theme.zip uploads
-------------------------------------+-----------------------
 Reporter:  jstrebel                 |       Owner:  dd32
     Type:  enhancement              |      Status:  accepted
 Priority:  normal                   |   Milestone:  3.3
Component:  Upgrade/Install          |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+-----------------------

Comment (by kezzbracey):

 I can see the reason for this enhancement, however it is definitely going
 to cause many thousands of users to receive the error message when the
 sole issue is there being no containing folder for a theme or plugin.

 This will be the case in a huge number of instances where said plugin or
 theme previously installed and ran perfectly.

 I myself experienced it just recently when playing with the beta, and
 posted about it here: http://wordpress.org/support/topic/plugintheme-
 installation-the-package-is-corrupt-or-not-in-the-correct-format

 The issues arose with themes and plugins that had worked perfectly in the
 past.

 The error message lead me to think there was an issue with the actual
 archive itself, so I ended up testing four different types of archiving
 processes to try and isolate whether it was a certain type of app that was
 creating the "corrupt" zip.

 I do feel that the number of plugins and themes out there that don't have
 a containing folder, (and hence won't be installable), will far outweigh
 the number of packages out there that have any other type of invalid
 folder structure.

 As a result, I suspect that if a lack of containing folder is not
 accounted for in some way, the check will actually cause a far higher
 number of problems than it actually solves.

 Could there not be some way to check if the only issue is lack of a
 containing folder, and then make an exception and proceed with
 installation in such a case?

 If so, could the archive not just be extracted into a folder of the same
 name, allowing it to install and function smoothly, just as the process
 has been up until now?

 If such a check can be done, it would allow for other forms of invalid
 folder structure to still be flagged, but without causing a huge wave of
 failed installations on all the themes and plugins out there with no
 containing folder that currently install and run perfectly.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/14999#comment:18>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software