[wp-trac] [WordPress Trac] #18991: Unnecessarily cryptic code when checking pagename= for verbose rules

WordPress Trac wp-trac at lists.automattic.com
Tue Oct 18 20:59:03 UTC 2011


#18991: Unnecessarily cryptic code when checking pagename= for verbose rules
--------------------------+------------------
 Reporter:  duck_         |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  3.3
Component:  General       |     Version:  3.3
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+------------------

Comment (by Otto42):

 That said, this would be a very good optimization, if you want to assume
 pagename will always = $matches[x]. I was originally thinking of pagename
 =something-static here, but the regexp won't account for that as written,
 so it's broken anyway for that case.

-- 
Ticket URL: <http://core.trac.wordpress.org/ticket/18991#comment:2>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software


More information about the wp-trac mailing list