[wp-trac] [WordPress Trac] #16434: Give site admin ability to upload favicon in Settings, General
WordPress Trac
wp-trac at lists.automattic.com
Mon Oct 17 15:40:22 UTC 2011
#16434: Give site admin ability to upload favicon in Settings, General
-----------------------------+-----------------------------
Reporter: jane | Owner:
Type: feature request | Status: new
Priority: normal | Milestone: Future Release
Component: Administration | Version: 3.1
Severity: normal | Resolution:
Keywords: 3.4-early |
-----------------------------+-----------------------------
Comment (by nacin):
`add_theme_support( 'favicon' );`
Core then provides a UI to upload/specify a favicon. Once specified, we
generate the <link> tag automatically.
Theme support is desired basically to ensure that the theme avoids
handling/printing an existing favicon. However I don't necessarily find
this to be a requirement -- we likely can echo out a favicon without much
side effect. Unsure if browsers rely on the last favicon specified.
(We could also even intercept `/favicon.ico` requests via .htaccess if
we're installed at the root and rewrite it to the uploaded file, and thus
specify a proper favicon.ico file in the <link>. As it is, though, core
does provide for an early exit with a 404 via PHP.)
Ultimately, though, we're going to need a DB option. In particular,
because my-sites and the admin bar will need to do get_blog_option()
against each blog. Any theme support will not be detectable. Perhaps we
could introduce get_blog_options() (or perhaps a deliberately more cryptic
name) that attempts to fetch all of the options we need for a single site
in a single query.
As an actual implementation, is favicon something for Settings, or for
Appearance? Our cognitive approach here will affect our code
implementation.
--
Ticket URL: <http://core.trac.wordpress.org/ticket/16434#comment:12>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list