[wp-trac] [WordPress Trac] #12367: Fixes for deprecated assignment of new objects by reference
WordPress Trac
wp-trac at lists.automattic.com
Wed Oct 12 17:58:49 UTC 2011
#12367: Fixes for deprecated assignment of new objects by reference
------------------------------+------------------------------
Reporter: technosailor | Owner: westi
Type: defect (bug) | Status: reopened
Priority: normal | Milestone: Awaiting Review
Component: Warnings/Notices | Version: 3.3
Severity: normal | Resolution:
Keywords: has-patch |
------------------------------+------------------------------
Comment (by mrtorrent):
Replying to [comment:12 nacin]:
> We don't hack external libraries for things like this, so let's exclude
TextDiff and SimplePie from the patch.
>
> Optionally, check to see if TextDiff has been updated upstream.
I can understand not wanting to fork functionally from a 3rd-party library
so that patches don't have to be maintained, but this is a small
compatibility fix that is essentially incorporated in newer versions of
both libraries. It fixes a current issue without breaking anything and
will not have to be forward-ported if the included versions are updated in
the future, so where's the harm?
--
Ticket URL: <http://core.trac.wordpress.org/ticket/12367#comment:13>
WordPress Trac <http://core.trac.wordpress.org/>
WordPress blogging software
More information about the wp-trac
mailing list